London | ITP-May-2025 | Seddiq Azam | Module-Structuring-and-Testing-Data | Sprint-3 #621
+4,900
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: Sprint-3/2-mandatory-rewrite/1-get-angle-type.js
modified: Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js
modified: Sprint-3/2-mandatory-rewrite/1-get-angle-type.test.js
modified: Sprint-3/2-mandatory-rewrite/2-is-proper-fraction.test.js
modified: Sprint-3/2-mandatory-rewrite/3-get-card-value.test.js
modified: Sprint-3/3-mandatory-practice/implement/count.test.js
modified: Sprint-3/3-mandatory-practice/implement/get-ordinal-number.test.js
modified: Sprint-3/3-mandatory-practice/implement/repeat.test.js
sedazam
added
📅 Sprint 3
new file: package-lock.json modified: package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
This PR includes updates and changes made across multiple Sprint 3 exercises, which include:
1-get-angle-type.jsImproved logic clarity and added corresponding test updates.
2-is-proper-fraction.jsRefined logic to correctly handle negative values and exceptional cases (e.g.,
-3/-4as a proper fraction).3-get-card-value.jsEnhanced handling for edge cases and improved code readability.
Practice Implementations
Added and updated various files (e.g.,
count.js,get-ordinal-number.js,repeat.js) to meet assignment requirements and ensure consistent behaviour.All updated files were tested to ensure correctness and alignment with the task specifications.
Questions
Ask any questions you have for your reviewer.